Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crush when intersection types used + Fix psalm + Kill mutants #86

Merged
merged 12 commits into from
Feb 18, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 9, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fix #79

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9512d94) 100.00% compared to head (6e83b95) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #86   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       242       242           
===========================================
  Files             16        16           
  Lines            664       653   -11     
===========================================
- Hits             664       653   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 9, 2024

PR Summary

  • Update of workflow configuration
    The integration protocol on the main development branch ('master') has been revised. We introduced a new process dubbed 'psalm80', configured specifically to meet our needs.

  • Upgrade of tool version
    We've enhanced our application by updating the version of vimeo/psalm, a crucial tool in our codebase, to a more advanced version (^5.21).

  • Improved error suppression
    An issue handler regarding RiskyTruthyFalsyComparison, an element that determines certain logical evaluations in our code, has been added. This enhancement aims to suppress errors for a smoother user experience.

  • Addition of custom configuration for new job
    A new file called 'psalm80.xml' has been created containing custom configurations for the 'psalm80' job. The configurations include specific parameters such as 'findUnusedBaselineEntry' and 'findUnusedCode' which intend to optimize the efficiency of the new job.

  • Expansion of issue handlers
    The issue handlers in psalm.xml have been updated with extra <referencedClass> elements. This broadens our ability to tackle issues effectively.

@vjik vjik added the status:under development Someone is working on a pull request. label Feb 9, 2024
@vjik vjik changed the title Fix psalm Fix crush when intersection types used + Fix psalm + Kill mutants Feb 15, 2024
@vjik vjik requested a review from a team February 15, 2024 19:21
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Feb 15, 2024
@samdark samdark requested review from xepozz and roxblnfk February 16, 2024 06:13
@vjik vjik merged commit f262d5d into master Feb 18, 2024
25 checks passed
@vjik vjik deleted the psalm branch February 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt package to intersection types and add PHP 8.2 to psalm CI
3 participants